Refactor: extract methods for parsing method input+output definitions #84
Conversation
|
Thank you for starting refactoring code. I wanted to make it simple as possible - having one function responsible for parsing input and other for generating output... but yeah, 180 commits later, so why not to start refactoring it little bit :) . I have to find some time to do code review, but I like your approach 👍 |
I understand making it as simple as possible 👍 My reason was that reducing the (cognitive) complexity of the parser would also make it more simple. I was thinking to move the 2 extracted functions This would shorten the parser code as well, making it easier to read. In addition, the split off functions would also be easier to grasp in isolation. What do you think? |
…ctor/parse-input-definitions
As a first step to lowering the complexity of the parser, I extracted two methods for parsing the method input and output definitions.
Both functions(
createMethodInputDefinitionandcreateMethodOutputDefinition) take an options hash and produce the respective definitions.Note that both functions cannot be reduced to one because their behavior is slightly different.